linux-kernel - Re: [PATCH] media: atomisp: use kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a289ccf-47b1-4e24-b317-53aaa166bb83@vivo.com>
Date: Thu, 21 Aug 2025 11:27:25 +0800
From: Qianfeng Rong <rongqianfeng@...o.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Andy Shevchenko <andy@...nel.org>, Hans de Goede <hansg@...nel.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Colin Ian King <colin.i.king@...il.com>, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] media: atomisp: use kmalloc_array() for array space
 allocation


在 2025/8/20 23:05, Andy Shevchenko 写道:
> On Sun, Aug 17, 2025 at 05:29:39PM +0800, Qianfeng Rong wrote:
>> Replace kmalloc(count * sizeof) with kmalloc_array() for safer memory
>> allocation and overflow prevention.
> ...
>
>> -	descr->in_info = kmalloc(descr->num_stage *
>> -				 sizeof(struct ia_css_frame_info),
>> -				 GFP_KERNEL);
>> +	descr->in_info = kmalloc_array(descr->num_stage,
>> +				       sizeof(struct ia_css_frame_info),
>> +				       GFP_KERNEL);
> At the same time it would be nice to use sizeof(*...) variants instead of using
> type-based.
I prefer sizeof(type), but using sizeof(*ptr) here shortens the line and 
is indeed better.

Best regards,
Qianfeng