[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <a3a7da4d-abec-4318-b326-39d55eb9bc30@redhat.com>
Date: Thu, 21 Aug 2025 15:58:45 +0000 (UTC)
From: Gabriele Monaco <gmonaco@...hat.com>
To: Nam Cao <namcao@...utronix.de>
Cc: linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
linux-trace-kernel@...r.kernel.org,
Tomas Glozar <tglozar@...hat.com>, Juri Lelli <jlelli@...hat.com>,
Clark Williams <williams@...hat.com>, John Kacur <jkacur@...hat.com>
Subject: Re: [RFC PATCH 09/17] verification/rvgen: Allow spaces in and
events strings
2025-08-21T15:15:36Z Nam Cao <namcao@...utronix.de>:
> We could also rewrite the parser using ply with a well-defined grammar and
> tokenizer, like how the LTL parser is implemented. Doing it this way would
> be easier to validate as well, because the grammar would be mostly
> copy-pasted from the specification.
Good idea, I can look into that and see how hard it's going to be (I'm not familiar with ply, but I see it's well documented).
>> Do you have specific examples of what doesn't work?
>
> Two things that I can remember:
>
> - breaking long lines
>
> - C-style and C++-style comments
>
Yeah those could break some assumptions (and they shouldn't), especially the line breaks.. And supporting it in the current parser may make it just uglier..
Thanks,
Gabriele
Powered by blists - more mailing lists