linux-kernel - Re: [PATCH net-next 02/15] net: phy: aquantia: merge aqr113c_fill_interface_modes() into aqr107_fill_interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0e40c1f-26e3-41aa-8db3-5757c69f0310@lunn.ch>
Date: Thu, 21 Aug 2025 18:20:46 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Daniel Golle <daniel@...rotopia.org>, linux-kernel@...r.kernel.org,
	Nikita Yushchenko <nikita.yoush@...entembedded.com>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Robert Marko <robimarko@...il.com>,
	Paweł Owoc <frut3k7@...il.com>,
	Sean Anderson <sean.anderson@...o.com>,
	Jon Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH net-next 02/15] net: phy: aquantia: merge
 aqr113c_fill_interface_modes() into aqr107_fill_interface_modes()

On Thu, Aug 21, 2025 at 06:20:09PM +0300, Vladimir Oltean wrote:
> I'm unsure whether intentionate or not, but I think the (partially
> observed) naming convention in this driver is that function prefixes
> denote the earliest generation when a feature is available. In case of
> aqr107_fill_interface_modes(), that means that the GLOBAL_CFG registers
> are a Gen2 feature. Supporting evidence: the AQR105, a Gen1 PHY, does
> not have these registers, thus the function is not named aqr105_*.

That is reasonably common. The Marvell PHY and DSA driver use the
same.

The other option would be to use gen1_, gen2_, gen3_ prefixes.

The Broadcom PHY uses an odd naming scheme, 28nm_, 16nm_, which i
assume is the silicon gate size of the generation.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew