lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250821033908.GE185832@quark>
Date: Wed, 20 Aug 2025 23:39:08 -0400
From: Eric Biggers <ebiggers@...nel.org>
To: linux-crypto@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>,
	"Jason A . Donenfeld" <Jason@...c4.com>
Subject: Re: [PATCH] lib/crypto: Drop inline from all *_mod_init_arch()
 functions

On Fri, Aug 15, 2025 at 07:04:57PM -0700, Eric Biggers wrote:
> Drop 'inline' from all the *_mod_init_arch() functions so that the
> compiler will warn about any bugs where they are unused due to not being
> wired up properly.  (There are no such bugs currently, so this just
> establishes a more robust convention for the future.  Of course, these
> functions also tend to get inlined anyway, regardless of the keyword.)
> 
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> ---
>  lib/crypto/arm/sha1.h     | 2 +-
>  lib/crypto/arm/sha256.h   | 2 +-
>  lib/crypto/arm/sha512.h   | 2 +-
>  lib/crypto/arm64/sha1.h   | 2 +-
>  lib/crypto/arm64/sha256.h | 2 +-
>  lib/crypto/arm64/sha512.h | 2 +-
>  lib/crypto/riscv/sha256.h | 2 +-
>  lib/crypto/riscv/sha512.h | 2 +-
>  lib/crypto/s390/sha1.h    | 2 +-
>  lib/crypto/s390/sha256.h  | 2 +-
>  lib/crypto/s390/sha512.h  | 2 +-
>  lib/crypto/sparc/md5.h    | 2 +-
>  lib/crypto/sparc/sha1.h   | 2 +-
>  lib/crypto/sparc/sha256.h | 2 +-
>  lib/crypto/sparc/sha512.h | 2 +-
>  lib/crypto/x86/sha1.h     | 2 +-
>  lib/crypto/x86/sha256.h   | 2 +-
>  lib/crypto/x86/sha512.h   | 2 +-
>  18 files changed, 18 insertions(+), 18 deletions(-)

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next

- Eric

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ