linux-kernel - Re: [PATCH] lib/crc: Drop inline from all *_mod_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250821033734.GD185832@quark>
Date: Wed, 20 Aug 2025 23:37:34 -0400
From: Eric Biggers <ebiggers@...nel.org>
To: linux-kernel@...r.kernel.org
Cc: linux-crypto@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH] lib/crc: Drop inline from all *_mod_init_arch() functions

On Fri, Aug 15, 2025 at 07:02:40PM -0700, Eric Biggers wrote:
> Drop 'inline' from all the *_mod_init_arch() functions so that the
> compiler will warn about any bugs where they are unused due to not being
> wired up properly.  (There are no such bugs currently, so this just
> establishes a more robust convention for the future.  Of course, these
> functions also tend to get inlined anyway, regardless of the keyword.)
> 
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> ---
>  lib/crc/arm/crc-t10dif.h     | 2 +-
>  lib/crc/arm/crc32.h          | 2 +-
>  lib/crc/arm64/crc-t10dif.h   | 2 +-
>  lib/crc/loongarch/crc32.h    | 2 +-
>  lib/crc/mips/crc32.h         | 2 +-
>  lib/crc/powerpc/crc-t10dif.h | 2 +-
>  lib/crc/powerpc/crc32.h      | 2 +-
>  lib/crc/sparc/crc32.h        | 2 +-
>  lib/crc/x86/crc-t10dif.h     | 2 +-
>  lib/crc/x86/crc32.h          | 2 +-
>  lib/crc/x86/crc64.h          | 2 +-
>  11 files changed, 11 insertions(+), 11 deletions(-)

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=crc-next

- Eric