linux-kernel - Re: [PATCH 11/11] mm/damon: add damon_ctx->min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250821173320.82616-1-sj@kernel.org>
Date: Thu, 21 Aug 2025 10:33:20 -0700
From: SeongJae Park <sj@...nel.org>
To: Quanmin Yan <yanquanmin1@...wei.com>
Cc: SeongJae Park <sj@...nel.org>,
	akpm@...ux-foundation.org,
	damon@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	wangkefeng.wang@...wei.com,
	zuoze1@...wei.com
Subject: Re: [PATCH 11/11] mm/damon: add damon_ctx->min_region

On Thu, 21 Aug 2025 18:51:59 +0800 Quanmin Yan <yanquanmin1@...wei.com> wrote:

> Adopting addr_unit would make DAMON_MINREGION 'addr_unit * 4096'
> bytes and cause data alignment issues[1].
> 
> Add damon_ctx->min_region to change DAMON_MIN_REGION from a global

s/min_region/min_sz_region/ ?

> macro value to per-context variable.
> 
> [1] https://lore.kernel.org/all/527714dd-0e33-43ab-bbbd-d89670ba79e7@huawei.com
> 
> Signed-off-by: Quanmin Yan <yanquanmin1@...wei.com>
> ---
>  include/linux/damon.h        |  4 ++-
>  mm/damon/core.c              | 67 ++++++++++++++++++++----------------
>  mm/damon/sysfs.c             |  8 +++--
>  mm/damon/tests/core-kunit.h  | 21 ++++++-----
>  mm/damon/tests/vaddr-kunit.h |  2 +-
>  mm/damon/vaddr.c             |  2 +-
>  6 files changed, 61 insertions(+), 43 deletions(-)
[...]
> @@ -1248,6 +1253,7 @@ int damon_commit_ctx(struct damon_ctx *dst, struct damon_ctx *src)
>  	}
>  	dst->ops = src->ops;
>  	dst->addr_unit = src->addr_unit;
> +	dst->min_sz_region = max(DAMON_MIN_REGION / src->addr_unit, 1);

Can't we set this as src->min_sz_region?

I asked a same question[1] to the previous version but seems it was missed.

[...]

Other parts look good to me.

[1] https://lore.kernel.org/20250820215612.86678-1-sj@kernel.org


Thanks,
SJ