linux-kernel - Re: [PATCH RFC net-next 12/23] net: dsa: lantiq_gswip: support 4k VLANs on API 2.2 or later

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKdazKJftVzb0yVt@pidgin.makrotopia.org>
Date: Thu, 21 Aug 2025 18:43:53 +0100
From: Daniel Golle <daniel@...rotopia.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>,
	"hauke@...ke-m.de" <hauke@...ke-m.de>,
	"olteanv@...il.com" <olteanv@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"linux@...linux.org.uk" <linux@...linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"arkadis@...lanox.com" <arkadis@...lanox.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	"horms@...nel.org" <horms@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"john@...ozen.org" <john@...ozen.org>,
	"Stockmann, Lukas" <lukas.stockmann@...mens.com>,
	"yweng@...linear.com" <yweng@...linear.com>,
	"fchan@...linear.com" <fchan@...linear.com>,
	"lxu@...linear.com" <lxu@...linear.com>,
	"jpovazanec@...linear.com" <jpovazanec@...linear.com>,
	"Schirm, Andreas" <andreas.schirm@...mens.com>,
	"Christen, Peter" <peter.christen@...mens.com>,
	"ajayaraman@...linear.com" <ajayaraman@...linear.com>,
	"bxu@...linear.com" <bxu@...linear.com>,
	"lrosu@...linear.com" <lrosu@...linear.com>
Subject: Re: [PATCH RFC net-next 12/23] net: dsa: lantiq_gswip: support 4k
 VLANs on API 2.2 or later

On Thu, Aug 21, 2025 at 07:03:35PM +0200, Andrew Lunn wrote:
> > > @@ -269,7 +270,8 @@ struct gswip_priv {
> > >  	struct dsa_switch *ds;
> > >  	struct device *dev;
> > >  	struct regmap *rcu_regmap;
> > > -	struct gswip_vlan vlans[64];
> > > +	struct gswip_vlan (*vlans)[];
> > 
> > ... if this would be just "struct gswip_vlan *vlans;"?
> 
> Could it be moved to the end of the structure and made into an
> flexible array?

I agree that it would be nice to get rid of the additional indirection,
I will implement it as flexible array when we arrive there (ie. after
both series of preparations have been merged).