linux-kernel - Re: [PATCH 3/9] crash_core: use panic_try_start() in crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3bfd0f8c-cda1-40fb-9642-bd305d3ff98f@gmail.com>
Date: Thu, 21 Aug 2025 11:41:39 +0800
From: Jinchao Wang <wangjinchao600@...il.com>
To: Baoquan He <bhe@...hat.com>
Cc: pmladek@...e.com, akpm@...ux-foundation.org,
 Vivek Goyal <vgoyal@...hat.com>, Dave Young <dyoung@...hat.com>,
 linux-kernel@...r.kernel.org, feng.tang@...ux.alibaba.com,
 joel.granados@...nel.org, john.ogness@...utronix.de, namcao@...utronix.de,
 sravankumarlpu@...il.com, kexec@...ts.infradead.org
Subject: Re: [PATCH 3/9] crash_core: use panic_try_start() in crash_kexec()

On 8/21/25 10:43, Baoquan He wrote:
> On 08/20/25 at 05:14pm, Jinchao Wang wrote:
>> crash_kexec() had its own code to exclude
>> parallel execution by setting panic_cpu.
>> This is already handled by panic_try_start().
>>
>> Switch to panic_try_start() to remove the
>> duplication and keep the logic consistent.
>>
>> Signed-off-by: Jinchao Wang <wangjinchao600@...il.com>
> 
> I had to use b4 to grab back the whole patchset, but I can't comment on
> other patches, especially the patch 1.
> 
> Firstly, this series looks interesting. It does enhance code
> readibility. But I am a vim user, I like open code on this one line of
> code wrapping. So leave this to other reviewers to decide if this should
> be accepted.
> 
> Secondly, the lines of your patch log are too short, it's not convenient
> for reading. Can you set your mail writer to change this.
> 
Thanks for the feedback. I will make sure to set my email client to use 
a wider line length for future patches.
> Thirdly, please add people to CC in all patches. I don't know why you
> only CC me in patch 3 if the whole patchset is related to crash and
> panic.
I use git send-email, which automatically adds the To and Cc headers 
based on these two configuration lines:
	tocmd = "scripts/get_maintainer.pl --norolestats --nol"
	ccCmd = "scripts/get_maintainer.pl --norolestats --nom"
It seems this isn't working very well. I'll find another configuration 
for the toCmd/ccCmd.
I would be very grateful if you could share your configuration or commands.

-- 
Best regards,
Jinchao