linux-kernel - Re: [PATCH v3 4/4] MAINTAINERS: Add entry for TM16xx driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250821-hardener-underpay-e30d1eb6de6b@spud>
Date: Thu, 21 Aug 2025 21:11:46 +0100
From: Conor Dooley <conor@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Jean-François Lessard <jefflessard3@...il.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	devicetree@...r.kernel.org, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Andreas Färber <afaerber@...e.de>,
	Boris Gjenero <boris.gjenero@...il.com>,
	Christian Hewitt <christianshewitt@...il.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Paolo Sabatino <paolo.sabatino@...il.com>,
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Subject: Re: [PATCH v3 4/4] MAINTAINERS: Add entry for TM16xx driver

On Thu, Aug 21, 2025 at 10:35:07PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 21, 2025 at 10:33 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Thu, Aug 21, 2025 at 8:40 PM Conor Dooley <conor@...nel.org> wrote:
> > > On Wed, Aug 20, 2025 at 11:29:47PM +0300, Andy Shevchenko wrote:
> > > > On Wed, Aug 20, 2025 at 10:52 PM Conor Dooley <conor@...nel.org> wrote:
> > > > > On Wed, Aug 20, 2025 at 10:08:06PM +0300, Andy Shevchenko wrote:
> > > > > > On Wed, Aug 20, 2025 at 7:31 PM Jean-François Lessard
> > > > > > <jefflessard3@...il.com> wrote:
> > > > > >
> > > > > > Besides the missing commit message, the main part of this patch should
> > > > > > be merged with the patch 2 where the YAML file is being added.
> > > > > > Otherwise it will be a dangling file. I dunno if DT tooling has its
> > > > > > own concept of a maintainer database, though.
> > > > >
> > > > > get_maintainer.pl will pull the maintainer out of the file, so it won't be
> > > > > truly dangling without a way to associate Jean-François with this file, if
> > > > > that;s what you mean.
> > > >
> > > > Let's assume patch 2 is applied and patch 4 is not, what will be the
> > > > result of get_maintainer.pl for the YAML file?
> > >
> > > Andy Shevchenko <andy@...nel.org> (maintainer:AUXILIARY DISPLAY DRIVERS)
> > > Geert Uytterhoeven <geert@...ux-m68k.org> (reviewer:AUXILIARY DISPLAY DRIVERS)
> > > Rob Herring <robh@...nel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > > Krzysztof Kozlowski <krzk+dt@...nel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > > Conor Dooley <conor+dt@...nel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> > > "Jean-François Lessard" <jefflessard3@...il.com> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:471/471=100%,in file)
> > >                                                                                                                     ^^^^^^^
> >
> > Which is a git lookup heuristics. If you disable that, there is no
> > maintainer for the file. Try with --m and --no-git (IIRC the option
> > name).

Also, I think linewrap might done some fuckery cos it was the
"in file" I was pointing to, pretty sure that's not coming from git.
I tried ./scripts/get_maintainer.pl --nogit --nogit-fallback -f Documentation/devicetree/bindings/auxdisplay/titanmec,tm16xx.yaml
(I think --nogit-fallback is the salient option, --nogit is a default
actually) and I got:
Andy Shevchenko <andy@...nel.org> (maintainer:AUXILIARY DISPLAY DRIVERS)
Geert Uytterhoeven <geert@...ux-m68k.org> (reviewer:AUXILIARY DISPLAY DRIVERS)
Rob Herring <robh@...nel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Krzysztof Kozlowski <krzk+dt@...nel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Conor Dooley <conor+dt@...nel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
"Jean-François Lessard" <jefflessard3@...il.com> (in file)
                                                  ^^^^^^^
and the in file still appears.
devicetree@...r.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-kernel@...r.kernel.org (open list)
AUXILIARY DISPLAY DRIVERS status: Odd Fixes

> Actually doesn't checkpatch complain in this case?

The usual warning about MAINTAINERS appears ye, the one that appears
whenever a file is moved, created or deleted. I personally don't care
about that, as long as the end result of a series deals with it since
the file will produce the correct maintainer list in a bisection etc
anyway. Of course, your subsystem your prerogative.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)