linux-kernel - Re: [PATCH] selftests/alsa: remove 0/NULL global variable assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c310ab7-0f0b-412f-8df7-71730a2d2caa@sirena.org.uk>
Date: Thu, 21 Aug 2025 21:49:29 +0100
From: Mark Brown <broonie@...nel.org>
To: "Nikola Z. Ivanov" <zlatistiv@...il.com>
Cc: perex@...ex.cz, tiwai@...e.com, shuah@...nel.org,
	linux-sound@...r.kernel.org, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] selftests/alsa: remove 0/NULL global variable assignment

On Thu, Aug 21, 2025 at 11:01:32PM +0300, Nikola Z. Ivanov wrote:
> Remove 0/NULL global variable assignment in mixer-test.c and pcm-test.c

Why?

> --- a/tools/testing/selftests/alsa/mixer-test.c
> +++ b/tools/testing/selftests/alsa/mixer-test.c
> @@ -53,10 +53,10 @@ struct ctl_data {
>  	struct ctl_data *next;
>  };
>  
> -int num_cards = 0;
> -int num_controls = 0;
> -struct card_data *card_list = NULL;
> -struct ctl_data *ctl_list = NULL;
> +int num_cards;
> +int num_controls;
> +struct card_data *card_list;
> +struct ctl_data *ctl_list;

Nothing now sets initial values for these variables so they all have
undefined values which is buggy.  The code is relying on the default
values.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)