linux-kernel - Re: [PATCH] selftests/alsa: remove 0/NULL global variable assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e9d15e2-d77f-4540-8528-0a7c60d7f92f@sirena.org.uk>
Date: Fri, 22 Aug 2025 00:14:00 +0100
From: Mark Brown <broonie@...nel.org>
To: "Nikola Z. Ivanov" <zlatistiv@...il.com>
Cc: perex@...ex.cz, tiwai@...e.com, shuah@...nel.org,
	linux-sound@...r.kernel.org, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] selftests/alsa: remove 0/NULL global variable assignment

On Fri, Aug 22, 2025 at 01:57:05AM +0300, Nikola Z. Ivanov wrote:
> On Thu, Aug 21, 2025 at 10:30:50PM +0100, Mark Brown wrote:

> > Do you have a reference there, note that these are just plain non-static
> > variables?  I wouldn't trust checkpatch for anything that isn't kernel
> > code (and even there it's got issues).

> This is what it says in the C99/C11/C18/C23 drafts I found:

...

> Since as you said checkpatch.pl is mostly intended for kernel code
> (which I was not aware of) this patch is probably not desired.
> In case it still is I can add quote to the draft and link it in the patch.

No, it's fine - thanks for checking the reference.  I suspected this
might be something specific to how the kernel is linked:

Reviewed-by: Mark Brown <broonie@...nel.org>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)