linux-kernel - Re: [PATCH v2 1/8] selftests/mm: Add -Wunreachable-code and fix warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46dce2ac-adb5-4a6b-8847-fe214c1599a7@collabora.com>
Date: Thu, 21 Aug 2025 11:19:20 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Kevin Brodsky <kevin.brodsky@....com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 David Hildenbrand <david@...hat.com>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>, Vlastimil Babka
 <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
 Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
 Jason Gunthorpe <jgg@...pe.ca>, John Hubbard <jhubbard@...dia.com>,
 Peter Xu <peterx@...hat.com>, Leon Romanovsky <leon@...nel.org>,
 Zi Yan <ziy@...dia.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>,
 Nico Pache <npache@...hat.com>, Ryan Roberts <ryan.roberts@....com>,
 Dev Jain <dev.jain@....com>, Barry Song <baohua@...nel.org>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Alexandre Ghiti <alex@...ti.fr>, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org,
 linux-riscv@...ts.infradead.org, Shuah Khan <shuah@...nel.org>
Cc: usama.anjum@...labora.com, kernel@...labora.com
Subject: Re: [PATCH v2 1/8] selftests/mm: Add -Wunreachable-code and fix
 warnings

On 8/18/25 1:10 PM, Kevin Brodsky wrote:
> On 31/07/2025 18:01, Muhammad Usama Anjum wrote:
>> [...]
>>
>> diff --git a/tools/testing/selftests/mm/pkey_sighandler_tests.c b/tools/testing/selftests/mm/pkey_sighandler_tests.c
>> index b5e076a564c95..302fef54049c8 100644
>> --- a/tools/testing/selftests/mm/pkey_sighandler_tests.c
>> +++ b/tools/testing/selftests/mm/pkey_sighandler_tests.c
>> @@ -41,7 +41,7 @@ static siginfo_t siginfo = {0};
>>   * syscall will attempt to access the PLT in order to call a library function
>>   * which is protected by MPK 0 which we don't have access to.
>>   */
>> -static inline __always_inline
>> +static __always_inline
> 
> Thanks for this, I had this fix locally but never got to post it!
> 
>>  long syscall_raw(long n, long a1, long a2, long a3, long a4, long a5, long a6)
>>  {
>>  	unsigned long ret;
>> diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c
>> index 05de1fc0005b7..a85b2e393e4e8 100644
>> --- a/tools/testing/selftests/mm/split_huge_page_test.c
>> +++ b/tools/testing/selftests/mm/split_huge_page_test.c
>> @@ -296,10 +296,8 @@ void split_file_backed_thp(int order)
>>  		ksft_exit_fail_msg("Unable to create a tmpfs for testing\n");
>>  
>>  	status = snprintf(testfile, INPUT_MAX, "%s/thp_file", tmpfs_loc);
>> -	if (status >= INPUT_MAX) {
>> +	if (status >= INPUT_MAX)
>>  		ksft_exit_fail_msg("Fail to create file-backed THP split testing file\n");
>> -		goto cleanup;
> 
> At that point the mount() call has succeeded so I think we do want to
> keep the goto and just print the error message instead of calling
> replace ksft_exit_fail_msg().
The cleanup tag does cleanup and then calls ksft_exit_fail_msg() without printing the
actual reason of failure. So current flow seems good where information about the error
is being printed.

> 
> - Kevin
> 
>> -	}
>>  
>>  	fd = open(testfile, O_CREAT|O_RDWR, 0664);
>>  	if (fd == -1) {

-- 
---
Thanks,
Usama