linux-kernel - Re: [PATCH] RDMA/erdma: Use vcalloc() instead of vzalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <176d4590-6cfd-8a39-a855-ee21105496b5@linux.alibaba.com>
Date: Thu, 21 Aug 2025 14:26:19 +0800
From: Cheng Xu <chengyou@...ux.alibaba.com>
To: Markus Elfring <Markus.Elfring@....de>,
 Qianfeng Rong <rongqianfeng@...o.com>, linux-rdma@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Jason Gunthorpe <jgg@...pe.ca>,
 Kai Shen <kaishen@...ux.alibaba.com>, Leon Romanovsky <leon@...nel.org>,
 Liao Yuanhong <liaoyuanhong@...o.com>
Subject: Re: [PATCH] RDMA/erdma: Use vcalloc() instead of vzalloc()



On 8/20/25 10:34 PM, Markus Elfring wrote:
>> Replace vzalloc() with vcalloc() in vmalloc_to_dma_addrs(). …
> 
> 
> 
> …
>> +++ b/drivers/infiniband/hw/erdma/erdma_verbs.c
>> @@ -671,7 +671,7 @@ static u32 vmalloc_to_dma_addrs(struct erdma_dev *dev, dma_addr_t **dma_addrs,
>>  
>>  	npages = (PAGE_ALIGN((u64)buf + len) - PAGE_ALIGN_DOWN((u64)buf)) >>
>>  		 PAGE_SHIFT;
>> -	pg_dma = vzalloc(npages * sizeof(dma_addr_t));
>> +	pg_dma = vcalloc(npages, sizeof(dma_addr_t));
> …
> 
> How do you think about to adjust also the size determination?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.17-rc2#n944
> 
> 	pg_dma = vcalloc(npages, sizeof(*pg_dma));
> 

Hi Qianfeng and Markus,

Both your changes look good to me.

Qianfeng, Could you send v2 including Markus's change?

Thanks,
Cheng Xu

> 
> Regards,
> Markus