linux-kernel - Re: [PATCH v4] usb: dt-bindings: ti,twlxxxx-usb: convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250821-dexterous-faithful-mole-add8ca@kuoka>
Date: Thu, 21 Aug 2025 09:29:03 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jihed Chaibi <jihed.chaibi.dev@...il.com>
Cc: robh@...nel.org, gregkh@...uxfoundation.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, peter.ujfalusi@...il.com, devicetree@...r.kernel.org, 
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH v4] usb: dt-bindings: ti,twlxxxx-usb: convert to DT schema

On Tue, Aug 19, 2025 at 11:55:25PM +0200, Jihed Chaibi wrote:
> +additionalProperties: false
> +
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        const: ti,twl6030-usb
> +then:
> +  required:
> +    - usb-supply
> +  properties:
> +    interrupts:
> +      minItems: 2
> +else:
> +  required:
> +    - usb1v5-supply
> +    - usb1v8-supply
> +    - usb3v1-supply
> +    - usb_mode

I think this should be just two bindings. Half of the properties are
different.

> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>

You do not use this header.

> +
> +    usb-phy{

Missing space {

> +        compatible = "ti,twl4030-usb";
> +
> +        // 1 interrupt: OTG (ID & VBUS events)

Drop comments, schema defines what is here.

> +        interrupts = <10 IRQ_TYPE_LEVEL_HIGH>;
> +        interrupt-parent = <&gic>;
> +
> +        usb1v5-supply = <&reg_vusb1v5>;
> +        usb1v8-supply = <&reg_vusb1v8>;
> +        usb3v1-supply  = <&reg_vusb3v1>;
> +        usb_mode = <1>;
> +
> +        #phy-cells = <0>;

Best regards,
Krzysztof