linux-kernel - [PATCH] pinctrl: mcp23s08: Don't change irq trigger type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250821081532.3084159-1-mastichi@gmail.com>
Date: Thu, 21 Aug 2025 11:15:32 +0300
From: Dmitry Mastykin <mastichi@...il.com>
To: Linus Walleij <linus.walleij@...aro.org>,
	linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Alexander Stein <alexander.stein@...tq-group.com>
Cc: Dmitry Mastykin <mastichi@...il.com>
Subject: [PATCH] pinctrl: mcp23s08: Don't change irq trigger type

IRQ polarity option "microchip,irq-active-high" not only sets polarity in
IOCON_INTPOL register, but also imposes trigger type to interrupt-parent.
Trigger type must be taken from device-tree "interrupts" property,
otherwise:
 - trigger type in device-tree unexpectedly doesn't correspond to real one;
 - it's impossible to use inverting level shifter between mcp and
   interrupt-parent;

Signed-off-by: Dmitry Mastykin <mastichi@...il.com>
---
 drivers/pinctrl/pinctrl-mcp23s08.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
index db3d616abf93..824c3cc6a6e6 100644
--- a/drivers/pinctrl/pinctrl-mcp23s08.c
+++ b/drivers/pinctrl/pinctrl-mcp23s08.c
@@ -572,16 +572,11 @@ static int mcp23s08_irq_setup(struct mcp23s08 *mcp)
 {
 	struct gpio_chip *chip = &mcp->chip;
 	int err;
-	unsigned long irqflags = IRQF_ONESHOT | IRQF_SHARED;
-
-	if (mcp->irq_active_high)
-		irqflags |= IRQF_TRIGGER_HIGH;
-	else
-		irqflags |= IRQF_TRIGGER_LOW;
 
 	err = devm_request_threaded_irq(chip->parent, mcp->irq, NULL,
 					mcp23s08_irq,
-					irqflags, dev_name(chip->parent), mcp);
+					IRQF_ONESHOT | IRQF_SHARED,
+					dev_name(chip->parent), mcp);
 	if (err != 0) {
 		dev_err(chip->parent, "unable to request IRQ#%d: %d\n",
 			mcp->irq, err);
-- 
2.34.1