linux-kernel - Re: [PATCH 1/2] media: ov02c10: Fix default vertical flip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f743a0d-3b96-4d85-8732-528218ec9dcc@kernel.org>
Date: Thu, 21 Aug 2025 09:31:07 +0100
From: Bryan O'Donoghue <bod@...nel.org>
To: Sebastian Reichel <sre@...nel.org>, Hans de Goede <hansg@...nel.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Heimir Thor Sverrisson <heimir.sverrisson@...il.com>,
 Hans Verkuil <hverkuil@...nel.org>
Cc: Frederic Stuyk <fstuyk@...box.com>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] media: ov02c10: Fix default vertical flip

On 20/08/2025 01:13, Sebastian Reichel wrote:
> The driver right now defaults to setting the vertical flip bit. This
> conflicts with proper handling of the rotation property defined in
> ACPI or device tree, so drop the VFLIP bit. It should be handled via
> V4L2_CID_VFLIP instead.
> 
> Reported-by: Frederic Stuyk <fstuyk@...box.com>
> Closes: https://lore.kernel.org/all/b6df9ae7-ea9f-4e5a-8065-5b130f534f37@runbox.com/
> Fixes: 44f89010dae0 ("media: i2c: Add Omnivision OV02C10 sensor driver")
> Signed-off-by: Sebastian Reichel <sre@...nel.org>
> ---
>   drivers/media/i2c/ov02c10.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
> index 089a4fd9627cf6c13efa65c104caeac370b53bc0..3a02fce0a9bc0ca3ab87defe3eefd04efb4012e7 100644
> --- a/drivers/media/i2c/ov02c10.c
> +++ b/drivers/media/i2c/ov02c10.c
> @@ -175,7 +175,7 @@ static const struct reg_sequence sensor_1928x1092_30fps_setting[] = {
>   	{0x3816, 0x01},
>   	{0x3817, 0x01},
> 
> -	{0x3820, 0xb0},
> +	{0x3820, 0xa0},
>   	{0x3821, 0x00},
>   	{0x3822, 0x80},
>   	{0x3823, 0x08},
> 
> --
> 2.50.1
> 
Reviewed-by: Bryan O'Donoghue <bod@...nel.org>