linux-kernel - Re: [PATCH v2 1/6] dt-bindings: clock: mediatek: Add power-domains property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6491baf3e08454f2ea042934f9f781cf21cbf4d7.camel@collabora.com>
Date: Thu, 21 Aug 2025 10:38:46 +0200
From: Julien Massot <julien.massot@...labora.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: kernel@...labora.com, Michael Turquette <mturquette@...libre.com>, 
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>,  Conor Dooley <conor+dt@...nel.org>,
 Matthias Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno	
 <angelogioacchino.delregno@...labora.com>, Ikjoon Jang <ikjn@...omium.org>,
  Enric Balletbo i Serra	 <eballetbo@...nel.org>, Chen-Yu Tsai
 <wenst@...omium.org>, Weiyi Lu	 <weiyi.lu@...iatek.com>, Eugen Hristev
 <eugen.hristev@...aro.org>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown
 <broonie@...nel.org>, Julien Massot <jmassot@...labora.com>,  Sean Wang
 <sean.wang@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 linux-clk@...r.kernel.org, 	devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, 	linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, 	linux-sound@...r.kernel.org,
 linux-gpio@...r.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: clock: mediatek: Add power-domains
 property

Hi Krzysztof, 

Thanks for the review
On Thu, 2025-08-21 at 09:30 +0200, Krzysztof Kozlowski wrote:
> On 21/08/2025 09:16, Krzysztof Kozlowski wrote:
> > On Wed, Aug 20, 2025 at 03:44:52PM +0200, Julien Massot wrote:
> > > The mt8183-mfgcfg node uses a power domain in its device tree node.
> > > To prevent schema validation warnings, add the optional `power-domains`
> > > property to the binding schema for mediatek syscon clocks.
> > > 
> > > Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
> > 
> > Checkpatch complains here, but more important - where is explanation of
> > dropped tag?

Right the proper tag is 
Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains properity to mfgcfg")

> > 
> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> > 
> > But this tag appeared? It wasn't even given!
> > 
> > You remove public tags and add tags never given on the lists.
> 
> I found Angelo's tag, but still dropping other acks is not explained.
> 
Regarding the tags: in v2 the patch changed quite a lot after I applied
Angelo's suggestion, so I decided to drop Rob’s Acked-by as it no longer
applies to the new version. I should have explained this in the changelog.

Regards,
Julien