| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202508211623.d8Spdqn7-lkp@intel.com>
Date: Thu, 21 Aug 2025 16:41:05 +0800
From: kernel test robot <lkp@...el.com>
To: Yulin Lu <luyulin@...incomputing.com>, dlemoal@...nel.org,
cassel@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, linux-ide@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
vkoul@...nel.org, kishon@...nel.org, linux-phy@...ts.infradead.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
ningyu@...incomputing.com, zhengyu@...incomputing.com,
linmin@...incomputing.com, huangyifeng@...incomputing.com,
fenglin@...incomputing.com, lianghujun@...incomputing.com,
luyulin <luyulin@...incomputing.com>
Subject: Re: [PATCH v2 3/3] phy: eswin: Create eswin directory and add
EIC7700 SATA PHY driver
Hi Yulin,
kernel test robot noticed the following build errors:
[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.17-rc2 next-20250820]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yulin-Lu/dt-bindings-ata-eswin-Document-for-EIC7700-SoC-ahci/20250820-213411
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20250819140043.1862-1-luyulin%40eswincomputing.com
patch subject: [PATCH v2 3/3] phy: eswin: Create eswin directory and add EIC7700 SATA PHY driver
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250821/202508211623.d8Spdqn7-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250821/202508211623.d8Spdqn7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508211623.d8Spdqn7-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/phy/eswin/phy-eic7700-sata.c:60:8: error: call to undeclared function 'readl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
60 | if ((readl(base + reg) & checkbit) == status)
| ^
drivers/phy/eswin/phy-eic7700-sata.c:79:8: error: call to undeclared function 'readl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
79 | val = readl(sata_phy->regs + SATA_CLK_CTRL);
| ^
>> drivers/phy/eswin/phy-eic7700-sata.c:81:2: error: call to undeclared function 'writel'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
81 | writel(val, sata_phy->regs + SATA_CLK_CTRL);
| ^
drivers/phy/eswin/phy-eic7700-sata.c:119:8: error: call to undeclared function 'readl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
119 | val = readl(sata_phy->regs + SATA_RESET_CTRL);
| ^
drivers/phy/eswin/phy-eic7700-sata.c:121:2: error: call to undeclared function 'writel'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
121 | writel(val, sata_phy->regs + SATA_RESET_CTRL);
| ^
drivers/phy/eswin/phy-eic7700-sata.c:172:8: error: call to undeclared function 'readl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
172 | val = readl(sata_phy->regs + SATA_CLK_CTRL);
| ^
drivers/phy/eswin/phy-eic7700-sata.c:174:2: error: call to undeclared function 'writel'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
174 | writel(val, sata_phy->regs + SATA_CLK_CTRL);
| ^
7 errors generated.
vim +/readl +60 drivers/phy/eswin/phy-eic7700-sata.c
52
53 static int wait_for_phy_ready(void __iomem *base, u32 reg, u32 checkbit,
54 u32 status)
55 {
56 unsigned long start = jiffies;
57 unsigned long timeout = start + PHY_READY_TIMEOUT;
58
59 while (time_before(start, timeout)) {
> 60 if ((readl(base + reg) & checkbit) == status)
61 return 0;
62 usleep_range(50, 70);
63 }
64
65 return -EFAULT;
66 }
67
68 static int eic7700_sata_phy_init(struct phy *phy)
69 {
70 struct eic7700_sata_phy *sata_phy = phy_get_drvdata(phy);
71 u32 val = 0;
72 int ret = 0;
73
74 /*
75 * The SATA_CLK_CTRL register offset controls the pmalive, rxoob,
76 * and rbc clocks gate provided by the PHY through the HSP bus,
77 * and it is not registered in the clock tree.
78 */
79 val = readl(sata_phy->regs + SATA_CLK_CTRL);
80 val |= SATA_SYS_CLK_EN;
> 81 writel(val, sata_phy->regs + SATA_CLK_CTRL);
82
83 writel(SATA_CLK_RST_SOURCE_PHY, sata_phy->regs + SATA_REF_CTRL1);
84 writel(SATA_P0_AMPLITUDE_GEN1 | SATA_P0_AMPLITUDE_GEN2 |
85 SATA_P0_AMPLITUDE_GEN3, sata_phy->regs + SATA_PHY_CTRL0);
86 writel(SATA_P0_PHY_TX_PREEMPH_GEN1 | SATA_P0_PHY_TX_PREEMPH_GEN2 |
87 SATA_P0_PHY_TX_PREEMPH_GEN3, sata_phy->regs + SATA_PHY_CTRL1);
88 writel(SATA_LOS_LEVEL | SATA_LOS_BIAS,
89 sata_phy->regs + SATA_LOS_IDEN);
90 writel(SATA_M_CSYSREQ | SATA_S_CSYSREQ,
91 sata_phy->regs + SATA_AXI_LP_CTRL);
92 writel(SATA_REF_REPEATCLK_EN | SATA_REF_USE_PAD,
93 sata_phy->regs + SATA_REG_CTRL);
94 writel(SATA_MPLL_MULTIPLIER, sata_phy->regs + SATA_MPLL_CTRL);
95 usleep_range(15, 20);
96
97 /*
98 * The SATA_RESET_CTRL register offset controls reset/deassert
99 * for both the port and the PHY through the HSP bus,
100 * and it is not registered in the reset tree.
101 */
102 val = readl(sata_phy->regs + SATA_RESET_CTRL);
103 val &= ~(SATA_PHY_RESET | SATA_PORT_RESET);
104 writel(val, sata_phy->regs + SATA_RESET_CTRL);
105
106 ret = wait_for_phy_ready(sata_phy->regs, SATA_P0_PHY_STAT,
107 SATA_P0_PHY_READY, 1);
108 if (ret < 0)
109 dev_err(&sata_phy->phy->dev,
110 "PHY READY check failed\n");
111 return ret;
112 }
113
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists