linux-kernel - Re: [PATCH] mailbox: arm_mhuv3: Remove dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aKbsjmEnXIOka7QM@bogus>
Date: Thu, 21 Aug 2025 10:53:18 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Xichao Zhao <zhao.xichao@...o.com>
Cc: <cristian.marussi@....com>, <jassisinghbrar@...il.com>,
	Sudeep Holla <sudeep.holla@....com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mailbox: arm_mhuv3: Remove dev_err_probe() if error is
 -ENOMEM

On Thu, Aug 21, 2025 at 05:32:53PM +0800, Xichao Zhao wrote:
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> Therefore, remove the useless call to dev_err_probe(), and just
> return the value instead.
> 

While I understand that it doesn't print the message for ENOMEM,

	grep dev_err_probe.*ENOMEM | wc -l

gave be 80 results, so not keen in just getting rid of one instance only.
No strong objection either if the subsystem maintainer prefers it this way.

-- 
Regards,
Sudeep