linux-kernel - Re: [PATCH net-next] amd-xgbe: Add PPS periodic output support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <03c92599-00e3-4481-a97d-1acd901d0ac0@redhat.com>
Date: Thu, 21 Aug 2025 11:58:30 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Raju Rangoju <Raju.Rangoju@....com>, netdev@...r.kernel.org
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, richardcochran@...il.com, linux-kernel@...r.kernel.org,
 Shyam-sundar.S-k@....com
Subject: Re: [PATCH net-next] amd-xgbe: Add PPS periodic output support

On 8/18/25 1:58 PM, Raju Rangoju wrote:
> @@ -122,6 +148,8 @@ void xgbe_ptp_register(struct xgbe_prv_data *pdata)
>  	info->adjtime = xgbe_adjtime;
>  	info->gettimex64 = xgbe_gettimex;
>  	info->settime64 = xgbe_settime;
> +	info->n_per_out = pdata->hw_feat.pps_out_num;
> +	info->n_ext_ts = pdata->hw_feat.aux_snap_num;

Both pps_out_num and aux_snap_num are read from 3 bits out of a
register, and I don't see any check to prevent such values exceeding the
limit hardcoded below (4). Why don't you need some additional sanity check?

Thanks,

Paolo