linux-kernel - Re: [PATCH 0/7] iio: Remove dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv63uvfHYATd7ZFweZ0LMfTLt-idHVgYJqOV8PvzaNeigbt9w@mail.gmail.com>
Date: Thu, 21 Aug 2025 13:50:00 +0200
From: Crt Mori <cmo@...exis.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Xichao Zhao <zhao.xichao@...o.com>, Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Andreas Klinger <ak@...klinger.de>, Haibo Chen <haibo.chen@....com>, 
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, 
	Marius Cristea <marius.cristea@...rochip.com>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>, 
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Heiko Stuebner <heiko@...ech.de>, 
	Francesco Dolcini <francesco@...cini.it>, 
	João Paulo Gonçalves <jpaulo.silvagoncalves@...il.com>, 
	Hugo Villeneuve <hvilleneuve@...onoff.com>, Gustavo Silva <gustavograzs@...il.com>, 
	Tomasz Duszynski <tomasz.duszynski@...akon.com>, Jagath Jog J <jagathjog1996@...il.com>, 
	Per-Daniel Olsson <perdaniel.olsson@...s.com>, Waqar Hameed <waqar.hameed@...s.com>, 
	Yasin Lee <yasin.lee.x@...il.com>, Julien Stephan <jstephan@...libre.com>, 
	"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, 
	"open list:NXP i.MX 7D/6SX/6UL/93 AND VF610 ADC DRIVER" <imx@...ts.linux.dev>, 
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, 
	"open list:ARM/Amlogic Meson SoC support" <linux-amlogic@...ts.infradead.org>, 
	"open list:ARM/Rockchip SoC support" <linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH 0/7] iio: Remove dev_err_probe() if error is -ENOMEM

Sorry duplicate - as I commented on driver.

On Thu, 21 Aug 2025 at 10:13, Andy Shevchenko <andy.shevchenko@...il.com> wrote:
>
> On Thu, Aug 21, 2025 at 11:07 AM Xichao Zhao <zhao.xichao@...o.com> wrote:
> >
> > The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
>
> when the error
>
> > Therefore, remove the useless call to dev_err_probe(), and just
> > return the value instead.
>
> In favour of this series,
> Reviewed-by: Andy Shevchenko <andy@...nel.org>
> (yes, I indeed looked at all patches in this one :-)
>
I am not sure I agree with this. It provides an error message with
reason and I understand we want as few as possible, but this would be
a valid remark inside the logs, but without it we only get error value
to figure out where it comes from?

> --
> With Best Regards,
> Andy Shevchenko