linux-kernel - Re: [PATCH] nvmet-fc: move lsop put work to nvmet_fc_ls_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5cf81b43-b173-4b36-a1df-f40cf395acfa@suse.de>
Date: Fri, 22 Aug 2025 14:55:23 +0200
From: Hannes Reinecke <hare@...e.de>
To: Daniel Wagner <wagi@...nel.org>, James Smart <james.smart@...adcom.com>,
 Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
 Chaitanya Kulkarni <kch@...dia.com>, Keith Busch <kbusch@...nel.org>,
 Daniel Wagner <dwagner@...e.de>
Cc: linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmet-fc: move lsop put work to nvmet_fc_ls_req_op

On 8/21/25 14:48, Daniel Wagner wrote:
> It’s possible for more than one async command to be in flight from
> __nvmet_fc_send_ls_req. For each command, a tgtport reference is taken.
> 
> In the current code, only one put work item is queued at a time, which
> results in a leaked reference.
> 
> To fix this, move the work item to the nvmet_fc_ls_req_op struct, which
> already tracks all resources related to the command.
> 
> Fixes: 710c69dbaccd ("nvmet-fc: avoid deadlock on delete association path")
> Signed-off-by: Daniel Wagner <wagi@...nel.org>
> ---
>   drivers/nvme/target/fc.c | 19 +++++++++----------
>   1 file changed, 9 insertions(+), 10 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich