linux-kernel - Re: [PATCH] pds_fwctl: Remove the use of dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250822131557.GA1121521@ziepe.ca>
Date: Fri, 22 Aug 2025 10:15:57 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Liao Yuanhong <liaoyuanhong@...o.com>
Cc: Brett Creeley <brett.creeley@....com>,
	Dave Jiang <dave.jiang@...el.com>,
	Saeed Mahameed <saeedm@...dia.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	"open list:FWCTL PDS DRIVER" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pds_fwctl: Remove the use of dev_err_probe()

On Wed, Aug 20, 2025 at 08:40:11PM +0800, Liao Yuanhong wrote:
> Logging messages that show some type of "out of memory" error are generally
> unnecessary as there is a generic message and a stack dump done by the
> memory subsystem. These messages generally increase kernel size without
> much added value[1].
> 
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
> remove the useless call to dev_err_probe(), and just return the value
> instead.
> 
> [1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/
> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
> ---
>  drivers/fwctl/pds/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied thanks

Jason