linux-kernel - Re: [PATCH] platform/x86: x86-android-tablets: Remove the use of dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2fc14ecb-537f-46e1-ae3d-0616f785d222@kernel.org>
Date: Fri, 22 Aug 2025 15:45:43 +0200
From: Hans de Goede <hansg@...nel.org>
To: Xichao Zhao <zhao.xichao@...o.com>, ilpo.jarvinen@...ux.intel.com
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: x86-android-tablets: Remove the use of
 dev_err_probe()

Hi,

On 20-Aug-25 10:51 AM, Xichao Zhao wrote:
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> Therefore, remove the useless call to dev_err_probe(), and just
> return the value instead.
> 
> Signed-off-by: Xichao Zhao <zhao.xichao@...o.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hansg@...nel.org>

Regards,

Hans



> ---
>  drivers/platform/x86/x86-android-tablets/core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/x86-android-tablets/core.c b/drivers/platform/x86/x86-android-tablets/core.c
> index 2a9c47178505..db76ba3abd7b 100644
> --- a/drivers/platform/x86/x86-android-tablets/core.c
> +++ b/drivers/platform/x86/x86-android-tablets/core.c
> @@ -265,8 +265,7 @@ static __init int x86_instantiate_spi_dev(const struct x86_dev_info *dev_info, i
>  	spi_devs[idx] = spi_new_device(controller, &board_info);
>  	put_device(&controller->dev);
>  	if (!spi_devs[idx])
> -		return dev_err_probe(&controller->dev, -ENOMEM,
> -				     "creating SPI-device %d\n", idx);
> +		return -ENOMEM;
>  
>  	return 0;
>  }