linux-kernel - Re: [PATCH] serial: stm32: allow selecting console when the driver is module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025082200-roamer-evasive-33ea@gregkh>
Date: Fri, 22 Aug 2025 15:45:12 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>
Cc: Jiri Slaby <jirislaby@...nel.org>, Arnd Bergmann <arnd@...nel.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	"Maciej W. Rozycki" <macro@...am.me.uk>,
	Douglas Anderson <dianders@...omium.org>,
	Zong Jiang <quic_zongjian@...cinc.com>,
	Robert Marko <robert.marko@...tura.hr>,
	Thierry Bultel <thierry.bultel.yh@...renesas.com>,
	Kartik Rajput <kkartik@...dia.com>,
	Peter Hurley <peter@...leysoftware.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>,
	Antonio Borneo <antonio.borneo@...s.st.com>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH] serial: stm32: allow selecting console when the driver
 is module

On Fri, Aug 22, 2025 at 03:37:53PM +0200, Raphael Gallais-Pou wrote:
> Console can be enabled on the UART compile as module.
> Change dependency to allow console mode when the driver is built as module.
> 
> Fixes: 48a6092fb41fa ("serial: stm32-usart: Add STM32 USART Driver")
> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>
> ---
>  drivers/tty/serial/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index e661f5951f558..1e27a822c1cba 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1420,7 +1420,7 @@ config SERIAL_STM32
>  
>  config SERIAL_STM32_CONSOLE
>  	bool "Support for console on STM32"
> -	depends on SERIAL_STM32=y
> +	depends on SERIAL_STM32
>  	select SERIAL_CORE_CONSOLE
>  	select SERIAL_EARLYCON
>  
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot