linux-kernel - RE: [PATCH v2 04/12] arm64: dts: fsd: Add CSI nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00d101dc136c$aa037020$fe0a5060$@samsung.com>
Date: Fri, 22 Aug 2025 19:27:09 +0530
From: "Inbaraj E" <inbaraj.e@...sung.com>
To: "'Krzysztof Kozlowski'" <krzk@...nel.org>, <mturquette@...libre.com>,
	<sboyd@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
	<conor+dt@...nel.org>, <s.nawrocki@...sung.com>, <s.hauer@...gutronix.de>,
	<shawnguo@...nel.org>, <cw00.choi@...sung.com>, <rmfrfs@...il.com>,
	<laurent.pinchart@...asonboard.com>, <martink@...teo.de>,
	<mchehab@...nel.org>, <linux-fsd@...la.com>, <will@...nel.org>,
	<catalin.marinas@....com>, <pankaj.dubey@...sung.com>,
	<shradha.t@...sung.com>, <ravi.patel@...sung.com>
Cc: <linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <alim.akhtar@...sung.com>,
	<linux-samsung-soc@...r.kernel.org>, <kernel@...i.sm>,
	<kernel@...gutronix.de>, <festevam@...il.com>,
	<linux-media@...r.kernel.org>, <imx@...ts.linux.dev>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v2 04/12] arm64: dts: fsd: Add CSI nodes


Hi Krzysztof,

Thanks for the review.

> 
> On 14/08/2025 16:09, Inbaraj E wrote:
> > There is a csi dma and csis interface that bundles together to allow
> 
> CSI DMA?
> What is CSIS?
> 
> > csi2 capture.
> 
> CSI2?

CSIS stands for Camera Serial Interface Slave.

Samsung v4.3 CSIS IP bundles both the CSIS link operation and the CSIS
DMA operation. The DMA-related operation are referred to as CSIS DMA and
are handled by the fsd-csis driver. The link related operations are
referred to simply as CSIS and are integrated into imx-mipi-csis driver.

I'll update the commit message and commit description accordingly,
and maintain consistency across the patches.

> 
> >
> > Signed-off-by: Inbaraj E <inbaraj.e@...sung.com>
> > ---
> >  arch/arm64/boot/dts/tesla/fsd-evb.dts |  96 +++++
> > +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> > @@ -493,6 +493,558 @@ clock_mfc: clock-controller@...10000 {
> >  			clock-names = "fin_pll";
> >  		};
> >
> > +		mipicsis0: mipi-csis@...40000 {
> 
> Messed ordering. See DTS coding style.

I'll fix the ordering in next patchset.

> 
> Node names should be generic. See also an explanation and list of examples
> (not exhaustive) in DT specification:
> https://protect2.fireeye.com/v1/url?k=a30d23f8-c28636dd-a30ca8b7-
> 74fe485cbff6-ee12f8a711c584c8&q=1&e=b96506d8-2d5d-4303-b9e8-
> 0e1189db1585&u=https%3A%2F%2Fdevicetree-
> specification.readthedocs.io%2Fen%2Flatest%2Fchapter2-devicetree-
> basics.html%23generic-names-recommendation
> 

There is no generic name directly related to CSI apart from camera. That's
why I used mipi-csis. If preferred, I can move the name to csis or simply csi.
Please let me know which one is more appropriate.

Regards,
Inbaraj E