linux-kernel - Re: [PATCH v2 0/8] Add AMD ISP4 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed9deffd-296c-465b-ad8a-314ed0968390@amd.com>
Date: Fri, 22 Aug 2025 10:23:48 +0800
From: "Du, Bin" <bin.du@....com>
To: Sultan Alsawaf <sultan@...neltoast.com>
Cc: mchehab@...nel.org, hverkuil@...all.nl,
 laurent.pinchart+renesas@...asonboard.com, bryan.odonoghue@...aro.org,
 sakari.ailus@...ux.intel.com, prabhakar.mahadev-lad.rj@...renesas.com,
 linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 pratap.nirujogi@....com, benjamin.chan@....com, king.li@....com,
 gjorgji.rosikopulos@....com, Phil.Jawich@....com, Dominic.Antony@....com,
 bin.du@....com, Mario Limonciello <mario.limonciello@....com>,
 Richard.Gong@....com, anson.tsao@....com
Subject: Re: [PATCH v2 0/8] Add AMD ISP4 driver

Thanks Sultan for the suggestion, sorry for the late response because we 
spent some time internally to discuss the feasibility.

On 8/14/2025 2:53 PM, Sultan Alsawaf wrote:
> On Wed, Jun 18, 2025 at 05:19:51PM +0800, Bin Du wrote:
>> AMD ISP4 Key features:
>> - Processes bayer raw data from the connected sensor and output them to different YUV formats
>> - Downscale input image to different output image resolution
>> - Pipeline to do image processing on the input image including demosaic, denoise, 3A, etc
> 
> BTW, another problem I have which I would love some help with: may I get the FW
> commands for setting basic 3A parameters?
> 
> It seems like the default AE mode does frame-averaging, which is really
> unsuitable for video calls on the webcam. My face is really underexposed as a
> result during the daytime because there's a lot of ambient light in the
> background.
> 
> The webcam on this laptop also has a very wide field of view, which makes my
> face appear small and shows too much of the background. This also exacerbates
> the AE problem.
> 
> I'm thinking CMD_ID_SET_ZOOM would fix the FOV problem, and then either
> CMD_ID_AE_SET_MODE to change the AE mode or CMD_ID_AE_SET_REGION to set the AE
> ROI would fix the exposure problem. What do you think?
> 
> Thanks,
> Sultan

Yes, it's really good suggestion. Because current V4l2 doesn't have 
standard ioctl for like region setting, to support it, besides adding FW 
command, new customized ioctl also needs be added and no existing APP 
can benefit from it. So our idea is not to add them to our current 
upstream driver, but we would be really glad to help you to enable them 
locally with dedicated thread, suppose it can help to improve the IQ 
with correct input setting like the correct ROI region, but we aren't 
sure because we didn't do that before on Linux and would really expect 
your test result and feedback.

-- 
Regards,
Bin