linux-kernel - Re: [PATCH] edac/amd76x: Remove assignment from if condition in amd76x_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250822144819.GAaKiDM8l-eJgU1-bs@fat_crate.local>
Date: Fri, 22 Aug 2025 16:48:19 +0200
From: Borislav Petkov <bp@...en8.de>
To: darshanrathod475@...il.com
Cc: tony.luck@...el.com, james.morse@....com, mchehab@...nel.org,
	rric@...nel.org, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] edac/amd76x: Remove assignment from if condition in
 amd76x_remove_one()

On Tue, Aug 12, 2025 at 06:31:54PM +0530, darshanrathod475@...il.com wrote:
> From: Darshan Rathod <darshanrathod475@...il.com>
> 
> The code was performing an assignment inside the if condition:
> 
>     if ((mci = edac_mc_del_mc(&pdev->dev)) == NULL)
> 
> This triggers a checkpatch.pl warning.

And?

Is this a bug or just something some silly script is telling you to do?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette