linux-kernel - Re: [PATCH v3 1/2] ACPI: processor: idle: Fix memory leak when register cpuidle device failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ir6ds5KGMQAUwb-hEdwhbuALHdYzDspT9z=W4md1rsOw@mail.gmail.com>
Date: Fri, 22 Aug 2025 21:27:38 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Huisong Li <lihuisong@...wei.com>
Cc: rafael@...nel.org, lenb@...nel.org, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linuxarm@...wei.com, 
	jonathan.cameron@...wei.com, zhanjie9@...ilicon.com, zhenglifeng1@...wei.com, 
	yubowen8@...wei.com, liuyonglong@...wei.com
Subject: Re: [PATCH v3 1/2] ACPI: processor: idle: Fix memory leak when
 register cpuidle device failed

On Mon, Jul 28, 2025 at 9:06 AM Huisong Li <lihuisong@...wei.com> wrote:
>
> The cpuidle device's memory has been leaked when register cpuidle
> device failed in acpi_processor_power_init().
>
> Fixes: 3d339dcbb56d ("cpuidle / ACPI : move cpuidle_device field out of the acpi_processor_power structure")
> Signed-off-by: Huisong Li <lihuisong@...wei.com>
> ---
>  drivers/acpi/processor_idle.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index 2c2dc559e0f8..031738390f2d 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -1405,6 +1405,8 @@ int acpi_processor_power_init(struct acpi_processor *pr)
>                 if (retval) {
>                         if (acpi_processor_registered == 0)
>                                 cpuidle_unregister_driver(&acpi_idle_driver);
> +                       kfree(dev);
> +                       per_cpu(acpi_cpuidle_device, pr->id) = NULL;
>                         return retval;
>                 }
>                 acpi_processor_registered++;
> --

Applied as 6.18 material with minor adjustments, thanks!