linux-kernel - Re: [PATCH v4 1/3] net: phy: mxl-86110: add basic support for led_brightness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3995276-2eb0-434c-b5c6-ba0cd7085171@lunn.ch>
Date: Fri, 22 Aug 2025 21:45:22 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Xu Liang <lxu@...linear.com>, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] net: phy: mxl-86110: add basic support for
 led_brightness_set op

On Fri, Aug 22, 2025 at 06:38:27PM +0100, Daniel Golle wrote:
> Add support for forcing each connected LED to be always on or always off
> by implementing the led_brightness_set() op.
> This is done by modifying the COM_EXT_LED_GEN_CFG register to enable
> force-mode and forcing the LED either on or off.
> When calling the led_hw_control_set() force-mode is again disabled for
> that LED.
> Implement mxl86110_modify_extended_reg() locked helper instead of
> manually acquiring and releasing the MDIO bus lock for single
> __mxl86110_modify_extended_reg() calls.
> 
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew