[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250822202016.GA297320-robh@kernel.org>
Date: Fri, 22 Aug 2025 15:20:16 -0500
From: Rob Herring <robh@...nel.org>
To: Baojun Xu <baojun.xu@...com>
Cc: broonie@...nel.org, tiwai@...e.de, andriy.shevchenko@...ux.intel.com,
13916275206@....com, alsa-devel@...a-project.org,
shenghao-ding@...com, linux-sound@...r.kernel.org,
linux-kernel@...r.kernel.org, lgirdwood@...il.com,
krzk+dt@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org,
k-yi@...com, henry.lo@...com, robinchen@...com, jesse-ji@...com,
will-wang@...com
Subject: Re: [PATCH v2 2/2] ASoC: tas2781: Add tas2118, tas2x20, tas5825
support
On Fri, Aug 22, 2025 at 01:14:09PM +0800, Baojun Xu wrote:
> Update ti,tas2781.yaml for added tas2118, tas2x20, tas5825.
>
> Signed-off-by: Baojun Xu <baojun.xu@...com>
>
> ---
> v2:
> - Update the mail list for maintainers of yaml file
> ---
> .../devicetree/bindings/sound/ti,tas2781.yaml | 73 ++++++++++++++++++-
> 1 file changed, 72 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> index 5ea1cdc593b5..fb57b63a00a2 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> -# Copyright (C) 2022 - 2023 Texas Instruments Incorporated
> +# Copyright (C) 2022 - 2025 Texas Instruments Incorporated
> %YAML 1.2
> ---
> $id: http://devicetree.org/schemas/sound/ti,tas2781.yaml#
> @@ -11,30 +11,62 @@ maintainers:
> - Shenghao Ding <shenghao-ding@...com>
>
> description: |
> + The TAS2118/TAS2X20 is mono, digital input Class-D audio amplifier
> + optimized for efficiently driving high peak power into small loudspeakers.
> + Integrated speaker voltage and current sense provides for
> + real time monitoring of loudspeaker behavior.
> The TAS2563/TAS2781 is a mono, digital input Class-D audio
> amplifier optimized for efficiently driving high peak power into
> small loudspeakers. An integrated on-chip DSP supports Texas
> Instruments Smart Amp speaker protection algorithm. The
> integrated speaker voltage and current sense provides for real time
> monitoring of loudspeaker behavior.
> + The TAS5825 is a stereo, digital input Class-D audio
> + amplifier optimized for efficiently driving high peak power into
> + small loudspeakers. An integrated on-chip DSP supports Texas
> + Instruments Smart Amp speaker protection algorithm. The
> + integrated speaker voltage and current sense provides for real time
> + monitoring of loudspeaker behavior.
>
> Specifications about the audio amplifier can be found at:
> + https://www.ti.com/lit/gpn/tas2120
> + https://www.ti.com/lit/gpn/tas2320
> https://www.ti.com/lit/gpn/tas2563
> https://www.ti.com/lit/gpn/tas2781
> + https://www.ti.com/lit/gpn/tas5825m
>
> properties:
> compatible:
> description: |
> + ti,tas2020: 3.2-W Mono Digital Input Class-D Speaker Amp with 5.5V PVDD
> + Support.
> +
> + ti,tas2118: 5-W Mono Digital Input Class-D Speaker Amp with Integrated
> + 8.4-V Class-H Boost.
> +
> + ti,tas2120: 8.2-W Mono Digital Input Class-D Speaker Amp with
> + Integrated 14.75V Class-H Boost.
> +
> + ti,tas2320: 15-W Mono Digital Input Class-D Speaker Amp with 15V Support.
> +
> ti,tas2563: 6.1-W Boosted Class-D Audio Amplifier With Integrated
> DSP and IV Sense, 16/20/24/32bit stereo I2S or multichannel TDM.
>
> ti,tas2781: 24-V Class-D Amplifier with Real Time Integrated Speaker
> Protection and Audio Processing, 16/20/24/32bit stereo I2S or
> multichannel TDM.
> +
> + ti,tas5825: 38-W Stereo, Inductor-Less, Digital Input, Closed-Loop 4.5V
> + to 26.4V Class-D Audio Amplifier with 192-kHz Extended Audio Processing.
> oneOf:
> - items:
> - enum:
> + - ti,tas2020
> + - ti,tas2118
> + - ti,tas2120
> + - ti,tas2320
> - ti,tas2563
> + - ti,tas5825
> - const: ti,tas2781
> - enum:
> - ti,tas2781
> @@ -61,6 +93,27 @@ required:
>
> allOf:
> - $ref: dai-common.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - ti,tas2020
> + - ti,tas2118
> + - ti,tas2120
> + - ti,tas2320
> + then:
> + properties:
> + reg:
> + description:
> + I2C address, in multiple-AMP case, all the i2c address
> + aggregate as one Audio Device to support multiple audio slots.
> + maxItems: 4
> + minItems: 1
1 is already the min items, so drop.
> + items:
> + minimum: 0x48
> + maximum: 0x4b
> +
> - if:
> properties:
> compatible:
> @@ -97,6 +150,24 @@ allOf:
> minimum: 0x38
> maximum: 0x3f
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - ti,tas5825
> + then:
> + properties:
> + reg:
> + description:
> + I2C address, in multiple-AMP case, all the i2c address
> + aggregate as one Audio Device to support multiple audio slots.
You've duplicated this. Does it belong at the top level 'reg'?
> + maxItems: 4
> + minItems: 1
Same here.
> + items:
> + minimum: 0x4c
> + maximum: 0x4f
> +
> additionalProperties: false
>
> examples:
> --
> 2.43.0
>
Powered by blists - more mailing lists