linux-kernel - Re: [PATCH net-next 07/15] net: phy: aquantia: remove handling for get_rate_matching(PHY_INTERFACE_MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be710bec-c68c-47c3-be4b-70db5481fedc@lunn.ch>
Date: Fri, 22 Aug 2025 05:22:02 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Daniel Golle <daniel@...rotopia.org>, linux-kernel@...r.kernel.org,
	Nikita Yushchenko <nikita.yoush@...entembedded.com>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Robert Marko <robimarko@...il.com>,
	Paweł Owoc <frut3k7@...il.com>,
	Sean Anderson <sean.anderson@...o.com>,
	Jon Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH net-next 07/15] net: phy: aquantia: remove handling for
 get_rate_matching(PHY_INTERFACE_MODE_NA)

On Thu, Aug 21, 2025 at 06:20:14PM +0300, Vladimir Oltean wrote:
> After commit 7642cc28fd37 ("net: phylink: fix PHY validation with rate
> adaption"), the API contract changed and PHY drivers are no longer
> required to respond to the .get_rate_matching() method for
> PHY_INTERFACE_MODE_NA. This was later followed up by documentation
> commit 6d4cfcf97986 ("net: phy: Update documentation for
> get_rate_matching").
> 
> As such, handling PHY_INTERFACE_MODE_NA in the Aquantia PHY driver
> implementation of this method is unnecessary and confusing. Remove it.
> 
> Cc: Sean Anderson <sean.anderson@...o.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew