linux-kernel - Re: [PATCH RESEND] PCI: Override PCIe bridge supported speeds for older Loongson 3C6000 series steppings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202508230402.VUq5Fewo-lkp@intel.com>
Date: Sat, 23 Aug 2025 04:26:42 +0800
From: kernel test robot <lkp@...el.com>
To: Ziyao via B4 Relay <devnull+liziyao.uniontech.com@...nel.org>,
	Bjorn Helgaas <helgaas@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
	niecheng1@...ontech.com, zhanjun@...ontech.com,
	guanwentao@...ontech.com, Kexy Biscuit <kexybiscuit@...c.io>,
	Lain Fearyncess Yang <fsf@...e.com>, Mingcong Bai <jeffbai@...c.io>,
	Ayden Meng <aydenmeng@...h.net>, Ziyao <liziyao@...ontech.com>
Subject: Re: [PATCH RESEND] PCI: Override PCIe bridge supported speeds for
 older Loongson 3C6000 series steppings

Hi Ziyao,

kernel test robot noticed the following build errors:

[auto build test ERROR on 3957a5720157264dcc41415fbec7c51c4000fc2d]

url:    https://github.com/intel-lab-lkp/linux/commits/Ziyao-via-B4-Relay/PCI-Override-PCIe-bridge-supported-speeds-for-older-Loongson-3C6000-series-steppings/20250822-171721
base:   3957a5720157264dcc41415fbec7c51c4000fc2d
patch link:    https://lore.kernel.org/r/20250822-loongson-pci1-v1-1-39aabbd11fbd%40uniontech.com
patch subject: [PATCH RESEND] PCI: Override PCIe bridge supported speeds for older Loongson 3C6000 series steppings
config: alpha-allnoconfig (https://download.01.org/0day-ci/archive/20250823/202508230402.VUq5Fewo-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250823/202508230402.VUq5Fewo-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508230402.VUq5Fewo-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from drivers/pci/quirks.c:21:
>> drivers/pci/quirks.c:1980:58: error: 'quirk_loongson_secondary_bridge_supported_speeds' undeclared here (not in a function); did you mean 'quirk_loongson_pci_bridge_supported_speeds'?
    1980 | DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LOONGSON, 0x3c19, quirk_loongson_secondary_bridge_supported_speeds);
         |                                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/pci.h:2318:57: note: in definition of macro 'DECLARE_PCI_FIXUP_SECTION'
    2318 |                 = { vendor, device, class, class_shift, hook };
         |                                                         ^~~~
   drivers/pci/quirks.c:1980:1: note: in expansion of macro 'DECLARE_PCI_FIXUP_HEADER'
    1980 | DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LOONGSON, 0x3c19, quirk_loongson_secondary_bridge_supported_speeds);
         | ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/pci/quirks.c:1965:13: warning: 'quirk_loongson_pci_bridge_supported_speeds' defined but not used [-Wunused-function]
    1965 | static void quirk_loongson_pci_bridge_supported_speeds(struct pci_dev *pdev)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +1980 drivers/pci/quirks.c

  1958	
  1959	/*
  1960	 * Older steppings of the Loongson 3C6000 series incorrectly report the
  1961	 * supported link speeds on their PCIe bridges (device IDs 3c19, 3c29) as
  1962	 * only 2.5 GT/s, despite the upstream bus supporting speeds from 2.5 GT/s
  1963	 * up to 16 GT/s.
  1964	 */
> 1965	static void quirk_loongson_pci_bridge_supported_speeds(struct pci_dev *pdev)
  1966	{
  1967		switch (pdev->bus->max_bus_speed) {
  1968		case PCIE_SPEED_16_0GT:
  1969			pdev->supported_speeds |= PCI_EXP_LNKCAP2_SLS_16_0GB;
  1970		case PCIE_SPEED_8_0GT:
  1971			pdev->supported_speeds |= PCI_EXP_LNKCAP2_SLS_8_0GB;
  1972		case PCIE_SPEED_5_0GT:
  1973			pdev->supported_speeds |= PCI_EXP_LNKCAP2_SLS_5_0GB;
  1974		case PCIE_SPEED_2_5GT:
  1975			pdev->supported_speeds |= PCI_EXP_LNKCAP2_SLS_2_5GB;
  1976		default:
  1977			break;
  1978		}
  1979	}
> 1980	DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LOONGSON, 0x3c19, quirk_loongson_secondary_bridge_supported_speeds);
  1981	DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LOONGSON, 0x3c29, quirk_loongson_secondary_bridge_supported_speeds);
  1982	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki