linux-kernel - Re: [PATCH next] of: dynamic: Fix use after free in of_changeset_add_prop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175589532447.468618.6588165651393821613.robh@kernel.org>
Date: Fri, 22 Aug 2025 15:42:06 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: devicetree@...r.kernel.org, Saravana Kannan <saravanak@...gle.com>,
	Lizhi Hou <lizhi.hou@....com>, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH next] of: dynamic: Fix use after free in
 of_changeset_add_prop_helper()


On Fri, 22 Aug 2025 11:08:46 +0300, Dan Carpenter wrote:
> If the of_changeset_add_property() function call fails, then this code
> frees "new_pp" and then dereference it on the next line.  Return the
> error code directly instead.
> 
> Fixes: c81f6ce16785 ("of: dynamic: Fix memleak when of_pci_add_properties() failed")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/of/dynamic.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 

Applied, thanks!