linux-kernel - Re: [GIT PULL] tracing: Fixes for v6.17

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250822235536.GA1367428@ax162>
Date: Fri, 22 Aug 2025 16:55:36 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Mark Rutland <mark.rutland@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Liao Yuanhong <liaoyuanhong@...o.com>,
	Pu Lehui <pulehui@...wei.com>, Tao Chen <chen.dylane@...ux.dev>,
	Tengda Wu <wutengda@...weicloud.com>,
	Ye Weihua <yeweihua4@...wei.com>
Subject: Re: [GIT PULL] tracing: Fixes for v6.17

On Fri, Aug 22, 2025 at 05:39:59PM -0400, Steven Rostedt wrote:
> On Fri, 22 Aug 2025 14:23:11 -0700
> Nathan Chancellor <nathan@...nel.org> wrote:
> 
> > > Actually, can you see if this fixes the bug you are seeing?  
> > 
> > Yes, it does.
> > 
> > Tested-by: Nathan Chancellor <nathan@...nel.org>
> 
> Ah, that patch isn't good, as iter->hash must be non NULL going forward,
> otherwise it thinks it failed to allocated.
> 
> Could you test this one instead?

Yes, this one works as well for that test.

> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index f992a5eb878e..a69067367c29 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -4662,7 +4662,10 @@ ftrace_regex_open(struct ftrace_ops *ops, int flag,
>  			iter->hash = alloc_and_copy_ftrace_hash(size_bits, hash);
>  		}
>  	} else {
> -		iter->hash = alloc_and_copy_ftrace_hash(hash->size_bits, hash);
> +		if (hash)
> +			iter->hash = alloc_and_copy_ftrace_hash(hash->size_bits, hash);
> +		else
> +			iter->hash = EMPTY_HASH;
>  	}
>  
>  	if (!iter->hash) {
> 
> 
> Thanks,
> 
> -- Steve