linux-kernel - Re: [PATCH] usb: gadget: configfs: Correctly set use_os

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025082244-celery-frenzy-2a70@gregkh>
Date: Fri, 22 Aug 2025 06:50:54 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: William Wu <william.wu@...k-chips.com>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	frank.wang@...k-chips.com, jianwei.zheng@...k-chips.com,
	yue.long@...k-chips.com
Subject: Re: [PATCH] usb: gadget: configfs: Correctly set use_os_string at
 bind

On Fri, Aug 22, 2025 at 11:36:09AM +0800, William Wu wrote:
> Once the use_os_string flag is set to true for some functions
> (e.g. adb/mtp) which need to response the OS string, and then
> if we re-bind the ConfigFS gadget to use the other functions
> (e.g. hid) which should not to response the OS string, however,
> because the use_os_string flag is still true, so the usb gadget
> response the OS string descriptor incorrectly, this can cause
> the USB device to be unrecognizable on the Windows system.
> 
> An example of this as follows:
> 
> echo 1 > os_desc/use
> ln -s functions/ffs.adb configs/b.1/function0
> start adbd
> echo "<udc device>" > UDC   #succeed
> 
> stop adbd
> rm configs/b.1/function0
> echo 0 > os_desc/use
> ln -s functions/hid.gs0 configs/b.1/function0
> echo "<udc device>" > UDC  #fail to connect on Windows
> 
> This patch sets the use_os_string flag to false at bind if
> the functions not support OS Descriptors.
> 
> Signed-off-by: William Wu <william.wu@...k-chips.com>

What commit id does this fix?

thanks,

greg k-h