linux-kernel - Re: [PATCH v4 1/2] iio: magnetometer: add support for Infineon TLV493D 3D Magentic sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfDR0UsjSufDQmO5+nx5jqoPL+qHgGRVMdH4Tp0+3wsoA@mail.gmail.com>
Date: Fri, 22 Aug 2025 09:11:53 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Dixit Parmar <dixitparmar19@...il.com>
Cc: Andy Shevchenko <andriy.shevchenko@...el.com>, Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 1/2] iio: magnetometer: add support for Infineon
 TLV493D 3D Magentic sensor

On Fri, Aug 22, 2025 at 5:40 AM Dixit Parmar <dixitparmar19@...il.com> wrote:
> On Thu, Aug 21, 2025 at 10:41:03AM +0300, Andy Shevchenko wrote:
> > On Thu, Aug 21, 2025 at 6:02 AM Dixit Parmar <dixitparmar19@...il.com> wrote:
> > > On Wed, Aug 20, 2025 at 05:08:38PM +0300, Andy Shevchenko wrote:

...

> > > > Interestingly that you have used 100 limit and suddenly don't do it here
> > > > and maybe elsewhere. Why inconsistent style? Please, go through the whole
> > > > file and make sure the style is consistent in all of the aspects:
> > > > - C style used
> > > > - comments style (one-line and multi-line)
> > > > - indentation
> > > > - etc.
> > > I tried to follow 80 limit(except few places where it was just on border or not
> > > clear to read). I belive the standard is to use 80 limit(correct me if I referred
> > > wrong place) and I will recheck to meet that.
> >
> > There are two standards, the old and strict one -- 80 characters, and
> > this subsystem _tries_ to follow it and relaxed with 100 limit.
> > The exceptions are possible when it affects readability.
> Understood, I will go with 100 limit and make sure everything is well within it.

It seems I was not clear enough. The IIO hardly tries to use the 80
limit, so don't go for 100 until it's agreed upon with the
maintainers.

-- 
With Best Regards,
Andy Shevchenko