linux-kernel - Re: [PATCH 2/6] phy: phy-can-transceiver: Add support for NXP TJA1051

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <060439dd-3df8-4d0b-8957-83b75dc13537@gocontroll.com>
Date: Fri, 22 Aug 2025 09:20:32 +0200
From: Maud Spierings <maudspierings@...ontroll.com>
To: peng.fan@....com
Cc: a-govindraju@...com, conor+dt@...nel.org, devicetree@...r.kernel.org,
 festevam@...il.com, frank.li@....com, haibo.chen@....com,
 imx@...ts.linux.dev, kernel@...gutronix.de, kishon@...nel.org,
 krzk+dt@...nel.org, linux-arm-kernel@...ts.infradead.org,
 linux-can@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-phy@...ts.infradead.org, mailhol.vincent@...adoo.fr,
 mkl@...gutronix.de, robh@...nel.org, s.hauer@...gutronix.de,
 shawnguo@...nel.org, vkoul@...nel.org
Subject: Re: [PATCH 2/6] phy: phy-can-transceiver: Add support for NXP TJA1051

Hi Peng,

> The TJA1051 is a high-speed CAN transceiver which is a pin-compatible
> alternative for TI TCAN1043 with Sleep mode supported.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>  drivers/phy/phy-can-transceiver.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-transceiver.c
> index f59caff4b3d4c267feca4220bf1547b6fad08f95..b49371a1272cd8a25b5e2271586b756103c64f0a 100644
> --- a/drivers/phy/phy-can-transceiver.c
> +++ b/drivers/phy/phy-can-transceiver.c
> @@ -85,6 +85,10 @@ static const struct of_device_id can_transceiver_phy_ids[] = {
>  		.compatible = "ti,tcan1043",
>  		.data = &tcan1043_drvdata
>  	},
> +	{
> +		.compatible = "nxp,tja1051",
> +		.data = &tcan1043_drvdata
> +	},
>  	{
>  		.compatible = "nxp,tjr1443",
>  		.data = &tcan1043_drvdata
> 
> -- 
> 2.37.1

Isn't this unnecessary as it has the ti,tcan1043 fallback compatible in 
the bindings? I'm still learning a lot so I might be wrong.

Kind regards,
Maud