linux-kernel - Re: [PATCH 1/2] tools/dma: move dma_map_benchmark from selftests to tools/dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGsJ_4yTOPoO98TTh3oQ4t6rag==yqeYP8HQ1wKvYdvg4e1RTQ@mail.gmail.com>
Date: Fri, 22 Aug 2025 13:12:07 +1200
From: Barry Song <21cnbao@...il.com>
To: Qinxin Xia <xiaqinxin@...wei.com>
Cc: m.szyprowski@...sung.com, robin.murphy@....com, 
	jonathan.cameron@...wei.com, prime.zeng@...wei.com, fanghao11@...wei.com, 
	linux-kernel@...r.kernel.org, linuxarm@...wei.com, yangyicong@...wei.com
Subject: Re: [PATCH 1/2] tools/dma: move dma_map_benchmark from selftests to tools/dma

>
> Does usr/include have header files? Did you run make headers_install
> before make?
> [xiaqinxin@...alhost linux]$ make headers_install
>    HOSTCC  scripts/basic/fixdep
>    HOSTCC  scripts/unifdef
>    WRAP    arch/arm64/include/generated/uapi/asm/socket.h
>    SYSHDR  arch/arm64/include/generated/uapi/asm/unistd_64.h
>    HDRINST usr/include/asm-generic/mman.h
>    HDRINST usr/include/asm-generic/stat.h
>    HDRINST usr/include/asm-generic/ucontext.h
>    HDRINST usr/include/asm-generic/int-ll64.h
>    HDRINST usr/include/asm-generic/unistd.h
>    HDRINST usr/include/asm-generic/kvm_para.h
>    HDRINST usr/include/asm-generic/types.h
>    HDRINST usr/include/asm-generic/ipcbuf.h
>    HDRINST usr/include/asm-generic/termbits-common.h
> ...
> [xiaqinxin@...alhost linux]$ cd tools/dma/
> [xiaqinxin@...alhost dma]$ make
> cc -I../../usr/include -I../../include dma_map_benchmark.c -o
> dma_map_benchmark

This is really frustrating. Why do other parts not need this, but
dma_map_benchmark does? It is also not acceptable to hardcode the
path to usr/include.

It is also not good practice to access a kernel header directly from a
userspace tool - such as -I../../include.

Shouldn't map_benchmark.h be a proper UAPI header that gets installed
into the toolchain like the others?

>
> My test is ok.


Thanks
Barry