linux-kernel - Re: [PATCH] net: macb: fix unregister_netdev call order in macb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175582561025.1263133.13241944786966815629.git-patchwork-notify@kernel.org>
Date: Fri, 22 Aug 2025 01:20:10 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: luoguangfei <15388634752@....com>
Cc: nicolas.ferre@...rochip.com, claudiu.beznea@...on.dev,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: macb: fix unregister_netdev call order in
 macb_remove()
 [v2]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Tue, 19 Aug 2025 07:25:27 +0800 you wrote:
> When removing a macb device, the driver calls phy_exit() before
> unregister_netdev(). This leads to a WARN from kernfs:
> 
>   ------------[ cut here ]------------
>   kernfs: can not remove 'attached_dev', no directory
>   WARNING: CPU: 1 PID: 27146 at fs/kernfs/dir.c:1683
>   Call trace:
>     kernfs_remove_by_name_ns+0xd8/0xf0
>     sysfs_remove_link+0x24/0x58
>     phy_detach+0x5c/0x168
>     phy_disconnect+0x4c/0x70
>     phylink_disconnect_phy+0x6c/0xc0 [phylink]
>     macb_close+0x6c/0x170 [macb]
>     ...
>     macb_remove+0x60/0x168 [macb]
>     platform_remove+0x5c/0x80
>     ...
> 
> [...]

Here is the summary with links:
  - net: macb: fix unregister_netdev call order in macb_remove() [v2]
    https://git.kernel.org/netdev/net/c/2df84b42f155

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html