| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1755828118-21640-1-git-send-email-william.wu@rock-chips.com> Date: Fri, 22 Aug 2025 10:01:58 +0800 From: William Wu <william.wu@...k-chips.com> To: gregkh@...uxfoundation.org Cc: Chris.Wulff@...mp.com, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, william.wu@...k-chips.com, frank.wang@...k-chips.com, jianwei.zheng@...k-chips.com, yue.long@...k-chips.com Subject: [PATCH] usb: gadget: f_hid: Fix zero length packet transfer If the hid transfer with size divisible to EPs max packet size, it needs to set the req->zero to true, then the usb controller can transfer a zero length packet at the end according to the USB 2.0 spec. Signed-off-by: William Wu <william.wu@...k-chips.com> --- drivers/usb/gadget/function/f_hid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c index 8e1d1e8..8021af3 100644 --- a/drivers/usb/gadget/function/f_hid.c +++ b/drivers/usb/gadget/function/f_hid.c @@ -511,7 +511,7 @@ static ssize_t f_hidg_write(struct file *file, const char __user *buffer, } req->status = 0; - req->zero = 0; + req->zero = ((count % hidg->in_ep->maxpacket) == 0); req->length = count; req->complete = f_hidg_req_complete; req->context = hidg; @@ -967,7 +967,7 @@ static int hidg_setup(struct usb_function *f, return -EOPNOTSUPP; respond: - req->zero = 0; + req->zero = ((length % cdev->gadget->ep0->maxpacket) == 0); req->length = length; status = usb_ep_queue(cdev->gadget->ep0, req, GFP_ATOMIC); if (status < 0) -- 2.0.0
Powered by blists - more mailing lists