linux-kernel - RE: [PATCH v2 net-next 5/5] net: fec: enable the Jumbo frame support for i.MX8QM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510185162C97023C953C96F883DA@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Fri, 22 Aug 2025 09:23:27 +0000
From: Wei Fang <wei.fang@....com>
To: Shenwei Wang <shenwei.wang@....com>
CC: Clark Wang <xiaoning.wang@....com>, Stanislav Fomichev <sdf@...ichev.me>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, dl-linux-imx <linux-imx@....com>, Andrew Lunn
	<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
	<daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>, John
 Fastabend <john.fastabend@...il.com>
Subject: RE: [PATCH v2 net-next 5/5] net: fec: enable the Jumbo frame support
 for i.MX8QM

> @@ -481,6 +483,11 @@ fec_enet_create_page_pool(struct fec_enet_private
> *fep,
>  	};
>  	int err;
> 
> +	if (fep->pagepool_order != 0) {
> +		pp_params.order = fep->pagepool_order;
> +		pp_params.max_len = fep->rx_frame_size;
> +	}
> +

We can move this logic to the initialization of pp_params, just as follows.

struct page_pool_params pp_params = {
		.order = fep->pagepool_order,
		[...]
		.max_len = fep->rx_frame_size,
};

A question: shouldn't this change be in the 4th patch ("net: fec: add change
mtu to support dynamic buffer allocation") ?