linux-kernel - Re: [PATCH] block: mtip32xx: Remove the redundant return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKg6B6buH5xYlnxL@smile.fi.intel.com>
Date: Fri, 22 Aug 2025 12:36:07 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Zhang Heng <zhangheng@...inos.cn>
Cc: axboe@...nel.dk, phasta@...nel.org, broonie@...nel.org,
	lizetao1@...wei.com, viro@...iv.linux.org.uk,
	fourier.thomas@...il.com, anuj20.g@...sung.com,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: mtip32xx: Remove the redundant return

On Fri, Aug 22, 2025 at 10:41:00AM +0800, Zhang Heng wrote:
> Remove the redundant return

Missing period.

...

>  iomap_err:
>  	kfree(dd);

>  	pci_set_drvdata(pdev, NULL);

I'm wondering if this also being redundant. I know about some corner cases, so
is this one of them, or can it be removed as well?

> -	return rv;
>  done:
>  	return rv;

-- 
With Best Regards,
Andy Shevchenko