linux-kernel - Re: [PATCH] crypto: octeontx2 - Call strscpy() with correct size argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKg471oRs3QB3xOm@gondor.apana.org.au>
Date: Fri, 22 Aug 2025 17:31:27 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Srujana Challa <schalla@...vell.com>,
	Bharat Bhushan <bbhushan2@...vell.com>,
	"David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>,
	Subbaraya Sundeep <sbhatta@...vell.com>,
	Sai Krishna <saikrishnag@...vell.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	Shijith Thotton <sthotton@...vell.com>,
	Sunil Kovvuri Goutham <sgoutham@...vell.com>,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: octeontx2 - Call strscpy() with correct size
 argument

On Mon, Aug 11, 2025 at 11:24:57AM +0200, Thorsten Blum wrote:
> In otx2_cpt_dl_custom_egrp_create(), strscpy() is called with the length
> of the source string rather than the size of the destination buffer.
> 
> This is fine as long as the destination buffer is larger than the source
> string, but we should still use the destination buffer size instead to
> call strscpy() as intended. And since 'tmp_buf' is a fixed-size buffer,
> we can safely omit the size argument and let strscpy() infer it using
> sizeof().
> 
> Fixes: d9d7749773e8 ("crypto: octeontx2 - add apis for custom engine groups")
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt