linux-kernel - Re: [PATCH v2 00/10] arm64: dts: qcom: x1: Add missing pinctrl for eDP HPD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xos3ayzhunyl24wu3nd2vqutvsx5dnffqrrp2xnouw2w43nmsw@mbfmcq75qgpn>
Date: Fri, 22 Aug 2025 12:40:26 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Stephan Gerhold <stephan.gerhold@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Aleksandrs Vinarskis <alex.vinarskis@...il.com>,
        Abel Vesa <abel.vesa@...aro.org>, Xilin Wu <wuxilin123@...il.com>,
        Jens Glathe <jens.glathe@...schoolsolutions.biz>,
        Srinivas Kandagatla <srini@...nel.org>,
        Sibi Sankar <quic_sibis@...cinc.com>,
        Rajendra Nayak <quic_rjendra@...cinc.com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Johan Hovold <johan@...nel.org>,
        Christopher Obbard <christopher.obbard@...aro.org>,
        Maud Spierings <maud_spierings@...mail.com>
Subject: Re: [PATCH v2 00/10] arm64: dts: qcom: x1: Add missing pinctrl for
 eDP HPD

On Fri, Aug 22, 2025 at 11:28:51AM +0200, Stephan Gerhold wrote:
> At the moment, we indirectly rely on the boot firmware to set up the
> pinctrl for the eDP HPD line coming from the internal display. If the boot
> firmware does not configure the display (e.g. because a different display
> is selected for output in the UEFI settings), then the display fails to
> come up and there are several errors in the kernel log:
> 
>  [drm:dpu_encoder_phys_vid_wait_for_commit_done:544] [dpu error]vblank timeout: 80020041
>  [drm:dpu_kms_wait_for_commit_done:524] [dpu error]wait for commit done returned -110
>  [drm:dpu_encoder_frame_done_timeout:2715] [dpu error]enc40 frame done timeout
>  ...
> 
> Fix this by adding the missing pinctrl for gpio119 for all the boards
> supported upstream, using a &edp0_hpd_default template in x1e80100.dtsi.
> 
> I ran into this issue on the X1E CRD while testing some things and had this
> fix in my local tree for a while. Chris made a similar patch for the T14s
> [1], this series fixes up all of the boards upstream.
> 
> [1]: https://lore.kernel.org/linux-arm-msm/20250731-wip-obbardc-qcom-t14s-oled-panel-v6-1-4782074104d1@linaro.org/
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold@...aro.org>
> ---
> Changes in v2:
> - Define &edp0_hpd_default template in the SoC dtsi and only reference it
>   individually for each board, since it is exactly the same for all the
>   boards upstream anyway (Dmitry)
> - The resulting DTBs are functionally still the same, so pick up tags from
>   previous version.
> - Link to v1: https://lore.kernel.org/r/20250814-x1e80100-add-edp-hpd-v1-0-a52804db53f6@linaro.org
> 

For the series:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>



-- 
With best wishes
Dmitry