linux-kernel - Re: [PATCH v2] serial: 8250_core: fix coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6503f380-1566-4efc-913d-125d316787d1@gmail.com>
Date: Fri, 22 Aug 2025 11:42:55 +0200
From: Osama Abdelkader <osama.abdelkader@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: jirislaby@...nel.org, ilpo.jarvinen@...ux.intel.com, mingo@...nel.org,
 john.ogness@...utronix.de, tglx@...utronix.de, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org
Subject: Re: [PATCH v2] serial: 8250_core: fix coding style issue


On 8/22/25 10:45 AM, Greg KH wrote:
> On Fri, Aug 22, 2025 at 10:23:10AM +0200, Osama Abdelkader wrote:
>> Fix a coding style issue in 8250_core.c:
>>
>> - Remove redundant NULL initialization of a global pointer
>>
>> Signed-off-by: Osama Abdelkader <osama.abdelkader@...il.com>
>> ---
>>  drivers/tty/serial/8250/8250_core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
>> index feb920c5b2e8..225bb7e4b89c 100644
>> --- a/drivers/tty/serial/8250/8250_core.c
>> +++ b/drivers/tty/serial/8250/8250_core.c
>> @@ -307,7 +307,7 @@ static void univ8250_release_irq(struct uart_8250_port *up)
>>  		serial_unlink_irq_chain(up);
>>  }
>>  
>> -const struct uart_ops *univ8250_port_base_ops = NULL;
>> +const struct uart_ops *univ8250_port_base_ops;
>>  struct uart_ops univ8250_port_ops;
>>  
>>  static const struct uart_8250_ops univ8250_driver_ops = {
>> -- 
>> 2.43.0
>>
>>
>
> Hi,
>
> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> a patch that has triggered this response.  He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created.  Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
>
> You are receiving this message because of the following common error(s)
> as indicated below:
>
> - This looks like a new version of a previously submitted patch, but you
>   did not list below the --- line any changes from the previous version.
>   Please read the section entitled "The canonical patch format" in the
>   kernel file, Documentation/process/submitting-patches.rst for what
>   needs to be done here to properly describe this.
>
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
>
> thanks,
>
> greg k-h's patch email bot

Hi All,

I forgot to include the changelog in v2.

v2:

- Dropped extra blank line after gpios declaration

Thanks,

Osama