linux-kernel - Re: [PATCH v2 1/3] dt-bindings: reset: Scope the compatible to VO subsystem explicitly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9542da82-af39-43a2-8a83-014e1484d6d5@kernel.org>
Date: Fri, 22 Aug 2025 11:45:00 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yao Zi <ziyao@...root.org>
Cc: Drew Fustini <fustini@...nel.org>, Guo Ren <guoren@...nel.org>,
 Fu Wei <wefu@...hat.com>, Philipp Zabel <p.zabel@...gutronix.de>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Paul Walmsley
 <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>,
 Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
 Michal Wilczynski <m.wilczynski@...sung.com>,
 linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Icenowy Zheng <uwu@...nowy.me>,
 Han Gao <rabenda.cn@...il.com>, Han Gao <gaohan@...as.ac.cn>,
 stable@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: reset: Scope the compatible to VO
 subsystem explicitly

On 22/08/2025 10:28, Yao Zi wrote:
> On Thu, Aug 21, 2025 at 09:54:08AM +0200, Krzysztof Kozlowski wrote:
>> On Wed, Aug 20, 2025 at 07:42:43AM +0000, Yao Zi wrote:
>>> The reset controller driver for the TH1520 was using the generic
>>> compatible string "thead,th1520-reset". However, the controller
>>> described by this compatible only manages the resets for the Video
>>> Output (VO) subsystem.
>>
>> Please use subject prefixes matching the subsystem. You can get them for
>> example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
>> your patch is touching. For bindings, the preferred subjects are
>> explained here:
>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 
> Thanks for your review, I appreciate it and will stick to
> thead,th1520-reset for the VO reset controller.
> 
> But I'm not very clear about the subject prefix: I already have a
> "dt-bindings: reset: " prefix, should I also make the subject more
> precise, including the exact file changed when changing a binding file?

Yes, as you can check in other commits. Your subject claims that you
change " Scope the compatible to VO subsystem explicitly" for all reset
controllers.

> 
> I've seen commits either with or without the precise name of the changed
> binding in subjects. For example,
> 
> a341bcfbfa7 dt-bindings: reset: add compatible for bcm63xx ephy control

But it says bcm63xx at least. Well, you will find plenty of poor
examples as well. I gave you template response because you made typical
mistake.

Anyway, you ignored rest of my response, so I assume you agree with it
completely.

Best regards,
Krzysztof