linux-kernel - Re: [PATCH RFC 26/35] mspro_block: drop nth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFrAth_76byLZG+5+CA1ZELJVH6XaFzfo2i7nYfnMYKa=A@mail.gmail.com>
Date: Fri, 22 Aug 2025 11:58:21 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: David Hildenbrand <david@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org, 
	linux-mm@...ck.org
Subject: Re: [PATCH RFC 26/35] mspro_block: drop nth_page() usage within SG entry

- trimmed cc-list

On Thu, 21 Aug 2025 at 22:08, David Hildenbrand <david@...hat.com> wrote:
>
> It's no longer required to use nth_page() when iterating pages within a
> single SG entry, so let's drop the nth_page() usage.
>
> Cc: Maxim Levitsky <maximlevitsky@...il.com>
> Cc: Alex Dubov <oakad@...oo.com>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Signed-off-by: David Hildenbrand <david@...hat.com>

Acked-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe




> ---
>  drivers/memstick/core/mspro_block.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
> index c9853d887d282..985cfca3f6944 100644
> --- a/drivers/memstick/core/mspro_block.c
> +++ b/drivers/memstick/core/mspro_block.c
> @@ -560,8 +560,7 @@ static int h_mspro_block_transfer_data(struct memstick_dev *card,
>                 t_offset += msb->current_page * msb->page_size;
>
>                 sg_set_page(&t_sg,
> -                           nth_page(sg_page(&(msb->req_sg[msb->current_seg])),
> -                                    t_offset >> PAGE_SHIFT),
> +                           sg_page(&(msb->req_sg[msb->current_seg])) + t_offset / PAGE_SIZE,
>                             msb->page_size, offset_in_page(t_offset));
>
>                 memstick_init_req_sg(*mrq, msb->data_dir == READ
> --
> 2.50.1
>