linux-kernel - Re: [PATCH] mmc: mmc_spi: remove unnecessary check in mmc_spi_setup_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFpHTktROvbW5ev6e_VGoVOUw=2EvRoMzmWLNfqoCPSykQ@mail.gmail.com>
Date: Fri, 22 Aug 2025 12:15:45 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, Rex Chen <rex.chen_1@....com>, 
	Huacai Chen <chenhuacai@...nel.org>, Binbin Zhou <zhoubinbin@...ngson.cn>, 
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] mmc: mmc_spi: remove unnecessary check in mmc_spi_setup_data_message()

On Thu, 21 Aug 2025 at 14:32, Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> An earlier commit changed the outer if statement from
> "if (multiple || write) {" to "if (write) {" so now we know that "write"
> is true and no longer need to check.  Delete the unnecessary check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mmc_spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
> index 95a32ff29ee1..42936e248c55 100644
> --- a/drivers/mmc/host/mmc_spi.c
> +++ b/drivers/mmc/host/mmc_spi.c
> @@ -566,7 +566,7 @@ mmc_spi_setup_data_message(struct mmc_spi_host *host, bool multiple, bool write)
>         if (write) {
>                 t = &host->early_status;
>                 memset(t, 0, sizeof(*t));
> -               t->len = write ? sizeof(scratch->status) : 1;
> +               t->len = sizeof(scratch->status);
>                 t->tx_buf = host->ones;
>                 t->rx_buf = scratch->status;
>                 t->cs_change = 1;
> --
> 2.47.2
>