linux-kernel - Re: [PATCH] ASoC: codecs: idt821034: fix wrong log in idt821034_chip_direction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250822124036.2855a5f0@bootlin.com>
Date: Fri, 22 Aug 2025 12:40:36 +0200
From: Herve Codina <herve.codina@...tlin.com>
To: Cryolitia PukNgae via B4 Relay
 <devnull+cryolitia.uniontech.com@...nel.org>
Cc: cryolitia@...ontech.com, Liam Girdwood <lgirdwood@...il.com>, Mark Brown
 <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
 <tiwai@...e.com>, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, guanwentao@...ontech.com,
 niecheng1@...ontech.com, zhanjun@...ontech.com
Subject: Re: [PATCH] ASoC: codecs: idt821034: fix wrong log in
 idt821034_chip_direction_output()

Hi Cryolitia,

On Fri, 22 Aug 2025 18:28:33 +0800
Cryolitia PukNgae via B4 Relay <devnull+cryolitia.uniontech.com@...nel.org> wrote:

> From: Cryolitia PukNgae <cryolitia@...ontech.com>
> 
> Change `dir in` to `dir out`
> 
> Suggested-by: Jun Zhan <zhanjun@...ontech.com>
> Signed-off-by: Cryolitia PukNgae <cryolitia@...ontech.com>
> ---
>  sound/soc/codecs/idt821034.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/idt821034.c b/sound/soc/codecs/idt821034.c
> index 6738cf21983b0dc58e162cbfaacaedb5edaaa245..a03d4e5e7d144195622ea0cbf6b6c6ba95642aa7 100644
> --- a/sound/soc/codecs/idt821034.c
> +++ b/sound/soc/codecs/idt821034.c
> @@ -1067,7 +1067,7 @@ static int idt821034_chip_direction_output(struct gpio_chip *c, unsigned int off
>  
>  	ret = idt821034_set_slic_conf(idt821034, ch, slic_conf);
>  	if (ret) {
> -		dev_err(&idt821034->spi->dev, "dir in gpio %d (%u, 0x%x) failed (%d)\n",
> +		dev_err(&idt821034->spi->dev, "dir out gpio %d (%u, 0x%x) failed (%d)\n",
>  			offset, ch, mask, ret);
>  	}
>  
> 
> ---
> base-commit: 3957a5720157264dcc41415fbec7c51c4000fc2d
> change-id: 20250822-idt821034-0b5cb86b0c96
> 

Thanks for the patch.

Acked-by: Herve Codina <herve.codina@...tlin.com>

Best regards,
Hervé